[Telemetry] Permanently hide the telemetry notice on dismissal #159893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afharo
added
Team:Core
|
Pinging @elastic/kibana-core (Team:Core) |
afharo
added
release_note:fix
and removed
release_note:skip
afharo
changed the title
lastVersionChecked on banner dismissal
💚 Build Succeeded
Metrics [docs]Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
To update your PR or re-run it, just comment with: cc @afharo |
pgayvallet
approved these changes
Jun 19, 2023
afharo
deleted the
telemetry-notices/update-lastversionchecked-on-dismissal
branch
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jun 19, 2023
…ic#159893) (cherry picked from commit 14c5fff)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jun 19, 2023
…159893) (#159922) # Backport This will backport the following commits from `main` to `8.8`: - [[Telemetry] Permanently hide the telemetry notice on dismissal (#159893)](#159893) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Alejandro Fernández Haro","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-06-19T12:43:41Z","message":"[Telemetry] Permanently hide the telemetry notice on dismissal (#159893)","sha":"14c5fffb24f25eb19e185582289a00ee71cf33af","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Core","release_note:fix","Feature:Telemetry","backport:prev-minor","v8.9.0"],"number":159893,"url":"https://github.com/elastic/kibana/pull/159893","mergeCommit":{"message":"[Telemetry] Permanently hide the telemetry notice on dismissal (#159893)","sha":"14c5fffb24f25eb19e185582289a00ee71cf33af"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/159893","number":159893,"mergeCommit":{"message":"[Telemetry] Permanently hide the telemetry notice on dismissal (#159893)","sha":"14c5fffb24f25eb19e185582289a00ee71cf33af"}}]}] BACKPORT--> Co-authored-by: Alejandro Fernández Haro <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #159870.
The reasoning for this bugfix is explained in this comment.
Note: I couldn't add a functional test to ensure this behavior is kept in the future because the banner is explicitly disabled in them (I assume it'd increase the CI execution if we add a step to dismiss the banners). I've created #159892 to tackle the FTR creation appropriately without the FF pressure.
For maintainers